Tracer doesn't continue spans for AbstractInternalSpanDecorator#9584
Merged
davsclaus merged 4 commits intoapache:camel-3.xfrom Mar 28, 2023
Merged
Tracer doesn't continue spans for AbstractInternalSpanDecorator#9584davsclaus merged 4 commits intoapache:camel-3.xfrom
davsclaus merged 4 commits intoapache:camel-3.xfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
oscerd
approved these changes
Mar 20, 2023
Contributor
Components tested:
|
davsclaus
approved these changes
Mar 21, 2023
Contributor
|
open tracing is deprecated so its most important for opentelemtry. |
Contributor
Author
|
Sure, but opentracing tests are also failing. I mean they can be skipped but I don't know if it's a good idea ;) |
marcingrzejszczak
force-pushed
the
issues_#19124
branch
from
7033251 to
724ce1e
Compare
Contributor
Author
|
I've updated OpenTelemetry tests and disabled tests in OpenTracing. Assuming that the build passes I think we're safe to merge this |
oscerd
approved these changes
Mar 22, 2023
davsclaus
approved these changes
Mar 22, 2023
Contributor
Components tested:
|
Contributor
Components tested:
|
Contributor
Author
|
This PR needs to be merged for Camel 3.x to work fine. This was fixed for the main branch of Camel. |
davsclaus
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes the issue in production code and updates tests for Micrometer Observations.
IMPORTANT: OpenTracing module has its tests skipped with this PR
fixes https://issues.apache.org/jira/browse/CAMEL-19124